Skip to content

Remove request prop from RokuDeploy class#84

Merged
TwitchBronBron merged 1 commit intomasterfrom
remove-request-property
Feb 16, 2022
Merged

Remove request prop from RokuDeploy class#84
TwitchBronBron merged 1 commit intomasterfrom
remove-request-property

Conversation

@TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Feb 16, 2022

Importing roku-deploy into a typescript project sometimes shows type errors because of a missing @types/request package. This is a devDependency, so it shouldn't clutter the production dependencies.

Also, we're only storing request on RokuDeploy to help with unit testing. However, we don't actually need to do that, since we can already stub/mock the request object as long as it's imported as import * as request from 'request'.

This might be a breaking change if any projects were utilizing the rokuDeploy.request property, but realistically that should have been a private property anyway, and there's an easy fix (import request in the host project...).

image

@TwitchBronBron TwitchBronBron merged commit 3096801 into master Feb 16, 2022
@TwitchBronBron TwitchBronBron deleted the remove-request-property branch February 16, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants